From 8b5b42537ab59b78d24dca35cb010f93ca71deb2 Mon Sep 17 00:00:00 2001 From: Sascha Hauer Date: Wed, 22 Mar 2017 12:36:40 +0100 Subject: state: pass struct state * to storage functions We can get a state_backend_storage * and the device * from struct state, so pass this to the storage functions rather than the two pointers. Signed-off-by: Sascha Hauer --- common/state/backend_storage.c | 7 +++---- common/state/state.c | 2 +- common/state/state.h | 3 +-- 3 files changed, 5 insertions(+), 7 deletions(-) (limited to 'common/state') diff --git a/common/state/backend_storage.c b/common/state/backend_storage.c index 5481f27df9..e1869830bd 100644 --- a/common/state/backend_storage.c +++ b/common/state/backend_storage.c @@ -454,7 +454,6 @@ static int state_storage_file_buckets_init(struct state_backend_storage *storage /** * state_storage_init - Init backend storage - * @param storage Storage object * @param path Path to the backend storage file * @param dev_offset Offset in the device to start writing at. * @param max_size Maximum size of the data. May be 0 for infinite. @@ -465,16 +464,16 @@ static int state_storage_file_buckets_init(struct state_backend_storage *storage * * Depending on the filetype, we create mtd buckets or normal file buckets. */ -int state_storage_init(struct state_backend_storage *storage, - struct device_d *dev, const char *path, +int state_storage_init(struct state *state, const char *path, off_t offset, size_t max_size, uint32_t stridesize, const char *storagetype) { + struct state_backend_storage *storage = &state->storage; int ret = -ENODEV; struct mtd_info_user meminfo; INIT_LIST_HEAD(&storage->buckets); - storage->dev = dev; + storage->dev = &state->dev; storage->name = storagetype; storage->stridesize = stridesize; diff --git a/common/state/state.c b/common/state/state.c index 87b704feba..8d2dca2523 100644 --- a/common/state/state.c +++ b/common/state/state.c @@ -602,7 +602,7 @@ struct state *state_new_from_node(struct device_node *node, char *path, if (ret) goto out_release_state; - ret = state_storage_init(&state->storage, &state->dev, path, offset, + ret = state_storage_init(state, path, offset, max_size, stridesize, storage_type); if (ret) goto out_release_state; diff --git a/common/state/state.h b/common/state/state.h index 254ff31a06..4ef46693c6 100644 --- a/common/state/state.h +++ b/common/state/state.h @@ -186,8 +186,7 @@ int backend_format_raw_create(struct state_backend_format **format, struct device_d *dev); int backend_format_dtb_create(struct state_backend_format **format, struct device_d *dev); -int state_storage_init(struct state_backend_storage *storage, - struct device_d *dev, const char *path, +int state_storage_init(struct state *state, const char *path, off_t offset, size_t max_size, uint32_t stridesize, const char *storagetype); void state_storage_set_readonly(struct state_backend_storage *storage); -- cgit v1.2.3