From 49831918036ab3292870dc2c6035292e6af47ae1 Mon Sep 17 00:00:00 2001 From: Sascha Hauer Date: Thu, 4 May 2017 12:27:21 +0200 Subject: state: Make an alias mandatory The userspace barebox-state utility gets confused when no alias exists. Make the alias mandatory, so that people make it right^tm without having to ask. Signed-off-by: Sascha Hauer --- common/state/state.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'common') diff --git a/common/state/state.c b/common/state/state.c index c3c8b768c7..41bee0fdc5 100644 --- a/common/state/state.c +++ b/common/state/state.c @@ -567,8 +567,10 @@ struct state *state_new_from_node(struct device_node *node, char *path, uint32_t stridesize; alias = of_alias_get(node); - if (!alias) - alias = node->name; + if (!alias) { + pr_err("State node %s does not have an alias in the /aliases/ node\n", node->full_name); + return ERR_PTR(-EINVAL); + } state = state_new(alias); if (IS_ERR(state)) -- cgit v1.2.3