From eaa73bfe0269554bf16697b1997475d9d738b290 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Wed, 29 Jan 2014 16:17:57 +0300 Subject: UBI: fix some use after free bugs Move the kmem_cache_free() calls down a couple lines. Signed-off-by: Dan Carpenter Signed-off-by: Artem Bityutskiy --- drivers/mtd/ubi/fastmap.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'drivers/mtd') diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c index de68c326da..50db661403 100644 --- a/drivers/mtd/ubi/fastmap.c +++ b/drivers/mtd/ubi/fastmap.c @@ -462,8 +462,8 @@ static int scan_pool(struct ubi_device *ubi, struct ubi_attach_info *ai, } } if (found_orphan) { - kfree(tmp_aeb); list_del(&tmp_aeb->u.list); + kfree(tmp_aeb); } new_aeb = kzalloc(sizeof(*new_aeb), GFP_KERNEL); @@ -835,16 +835,16 @@ fail_bad: ret = UBI_BAD_FASTMAP; fail: list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &used, u.list) { - free(tmp_aeb); list_del(&tmp_aeb->u.list); + free(tmp_aeb); } list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &eba_orphans, u.list) { - free(tmp_aeb); list_del(&tmp_aeb->u.list); + free(tmp_aeb); } list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &lfree, u.list) { - free(tmp_aeb); list_del(&tmp_aeb->u.list); + free(tmp_aeb); } return ret; -- cgit v1.2.3