From 75fa85c5856cef4b9944f6bd7f1ccec38e20e000 Mon Sep 17 00:00:00 2001 From: Andrey Smirnov Date: Wed, 6 Feb 2019 17:22:07 -0800 Subject: net/e1000: Remove pointer arithmetic in e1000_transmit() Instead of relying on reles of pointer arithmetic (implicit multiplication by the size of pointer type), change the code to retreive address of an array elemet to clarify the intent. Signed-off-by: Andrey Smirnov Signed-off-by: Sascha Hauer --- drivers/net/e1000/main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'drivers/net/e1000') diff --git a/drivers/net/e1000/main.c b/drivers/net/e1000/main.c index b8222c7ae2..f7e26a0e58 100644 --- a/drivers/net/e1000/main.c +++ b/drivers/net/e1000/main.c @@ -3413,12 +3413,11 @@ static int e1000_poll(struct eth_device *edev) static int e1000_transmit(struct eth_device *edev, void *txpacket, int length) { struct e1000_hw *hw = edev->priv; - volatile struct e1000_tx_desc *txp; + volatile struct e1000_tx_desc *txp = &hw->tx_base[hw->tx_tail]; uint64_t to; dma_addr_t dma; int ret = 0; - txp = hw->tx_base + hw->tx_tail; hw->tx_tail = (hw->tx_tail + 1) % 8; txp->lower.data = cpu_to_le32(hw->txd_cmd | length); -- cgit v1.2.3