From 2731cc09db884b5089d027a412e0396d07d23f42 Mon Sep 17 00:00:00 2001 From: Ahmad Fatoum Date: Wed, 23 Oct 2019 18:55:58 +0200 Subject: watchdog: efi: bump down priority below default The barebox EFI documentation notes: > Current linux kernel (v5.0) will execute ExitBootServices() during the > early boot stage and thus will automatically disable the (U)EFI watchdog. > Since it is the proper behavior according to the (U)EFI specification, it > is impossible to protect full boot chain by using this watchdog only. > It is recommended to use an alternative hardware watchdog Heed the advice and bump down the EFI watchdog priority below the watchdog priority default. This ensures the EFI watchdog isn't inadvertently used if other watchdogs are registered. Signed-off-by: Ahmad Fatoum Signed-off-by: Sascha Hauer --- drivers/watchdog/efi_wdt.c | 1 + 1 file changed, 1 insertion(+) (limited to 'drivers/watchdog/efi_wdt.c') diff --git a/drivers/watchdog/efi_wdt.c b/drivers/watchdog/efi_wdt.c index 8e3e51b7a9..ea1ede1381 100644 --- a/drivers/watchdog/efi_wdt.c +++ b/drivers/watchdog/efi_wdt.c @@ -41,6 +41,7 @@ static int efi_wdt_probe(struct device_d *dev) priv->wd.set_timeout = efi_wdt_set_timeout; priv->wd.hwdev = dev; priv->dev = dev; + priv->wd.priority = WATCHDOG_DEFAULT_PRIORITY - 50; dev->priv = priv; -- cgit v1.2.3