From 27166fb0b1eaa538555fe1306b5ca8922520584f Mon Sep 17 00:00:00 2001 From: Sascha Hauer Date: Fri, 15 Mar 2019 07:57:15 +0100 Subject: treewide: Make locally used functions static Many functions are only used locally but still are globally visible. Make these function static. Avoids warnings generated with -Wmissing-prototypes Signed-off-by: Sascha Hauer --- drivers/clk/mvebu/common.c | 4 ++-- drivers/clk/mxs/clk-imx23.c | 2 +- drivers/clk/mxs/clk-imx28.c | 2 +- drivers/clocksource/mvebu.c | 2 +- drivers/net/mvneta.c | 2 +- drivers/usb/otg/twl4030.c | 2 +- drivers/w1/slaves/w1_ds2431.c | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) (limited to 'drivers') diff --git a/drivers/clk/mvebu/common.c b/drivers/clk/mvebu/common.c index f6f118f0db..609e63697c 100644 --- a/drivers/clk/mvebu/common.c +++ b/drivers/clk/mvebu/common.c @@ -42,7 +42,7 @@ static struct of_device_id mvebu_coreclk_ids[] = { { } }; -int mvebu_coreclk_probe(struct device_d *dev) +static int mvebu_coreclk_probe(struct device_d *dev) { struct resource *iores; struct device_node *np = dev->device_node; @@ -155,7 +155,7 @@ static struct of_device_id mvebu_clk_gating_ids[] = { { } }; -int mvebu_clk_gating_probe(struct device_d *dev) +static int mvebu_clk_gating_probe(struct device_d *dev) { struct resource *iores; struct device_node *np = dev->device_node; diff --git a/drivers/clk/mxs/clk-imx23.c b/drivers/clk/mxs/clk-imx23.c index e28dae12f1..526efc52be 100644 --- a/drivers/clk/mxs/clk-imx23.c +++ b/drivers/clk/mxs/clk-imx23.c @@ -61,7 +61,7 @@ enum imx23_clk { static struct clk *clks[clk_max]; -int __init mx23_clocks_init(void __iomem *regs) +static int __init mx23_clocks_init(void __iomem *regs) { clks[ref_xtal] = mxs_clk_fixed("ref_xtal", 24000000); clks[pll] = mxs_clk_pll("pll", "ref_xtal", PLLCTRL0, 16, 480000000); diff --git a/drivers/clk/mxs/clk-imx28.c b/drivers/clk/mxs/clk-imx28.c index dd17a74d79..12bc9dd977 100644 --- a/drivers/clk/mxs/clk-imx28.c +++ b/drivers/clk/mxs/clk-imx28.c @@ -74,7 +74,7 @@ enum imx28_clk { static struct clk *clks[clk_max]; -int __init mx28_clocks_init(void __iomem *regs) +static int __init mx28_clocks_init(void __iomem *regs) { clks[ref_xtal] = clk_fixed("ref_xtal", 24000000); clks[pll0] = mxs_clk_pll("pll0", "ref_xtal", PLL0CTRL0, 17, 480000000); diff --git a/drivers/clocksource/mvebu.c b/drivers/clocksource/mvebu.c index 59bbc4be22..b55d72a343 100644 --- a/drivers/clocksource/mvebu.c +++ b/drivers/clocksource/mvebu.c @@ -43,7 +43,7 @@ static __iomem void *timer_base; -uint64_t mvebu_clocksource_read(void) +static uint64_t mvebu_clocksource_read(void) { return 0 - __raw_readl(timer_base + TIMER0_VAL_OFF); } diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c index 7aa54a292d..359c70c927 100644 --- a/drivers/net/mvneta.c +++ b/drivers/net/mvneta.c @@ -580,7 +580,7 @@ static void mvneta_init_rx_ring(struct mvneta_port *priv) priv->curr_rxdesc = 0; } -void mvneta_setup_tx_rx(struct mvneta_port *priv) +static void mvneta_setup_tx_rx(struct mvneta_port *priv) { u32 val; diff --git a/drivers/usb/otg/twl4030.c b/drivers/usb/otg/twl4030.c index fd5f593dc6..3668870b9e 100644 --- a/drivers/usb/otg/twl4030.c +++ b/drivers/usb/otg/twl4030.c @@ -64,7 +64,7 @@ static int twl4030_usb_read(u8 address) return ret; } -void twl4030_power_init(void) +static void twl4030_power_init(void) { unsigned char byte; struct twl4030 *twl4030 = twl4030_get(); diff --git a/drivers/w1/slaves/w1_ds2431.c b/drivers/w1/slaves/w1_ds2431.c index 6446f4ba05..ab2ceffa42 100644 --- a/drivers/w1/slaves/w1_ds2431.c +++ b/drivers/w1/slaves/w1_ds2431.c @@ -60,7 +60,7 @@ static inline size_t ds2431_fix_count(loff_t off, size_t count, size_t size) * * count must not exceed W1_F2D_READ_MAXLEN. */ -int ds2431_readblock(struct w1_device *dev, int off, int count, char *buf) +static int ds2431_readblock(struct w1_device *dev, int off, int count, char *buf) { struct w1_bus *bus = dev->bus; u8 wrbuf[3]; -- cgit v1.2.3 From 07b1c63db8eefeb69d6e0644446ff14aacbb7ae2 Mon Sep 17 00:00:00 2001 From: Sascha Hauer Date: Mon, 18 Mar 2019 10:00:57 +0100 Subject: treewide: Add missing includes Many files in the tree implement functions, but do not include the header files which provide the prototypes for these functions. This means conflicting prototypes remain undetected. Add the missing includes. Signed-off-by: Sascha Hauer --- arch/arm/boards/crystalfontz-cfa10036/hwdetect.c | 2 ++ arch/arm/boards/friendlyarm-tiny6410/tiny6410.c | 2 ++ arch/arm/lib32/semihosting.c | 1 + arch/arm/mach-clps711x/devices.c | 1 + arch/arm/mach-ep93xx/gpio.c | 1 + arch/arm/mach-ep93xx/led.c | 2 ++ arch/arm/mach-mvebu/common.c | 1 + arch/arm/mach-mxs/power.c | 1 + arch/arm/mach-mxs/usb-imx23.c | 1 + arch/arm/mach-mxs/usb-imx28.c | 1 + arch/arm/mach-netx/generic.c | 1 + arch/arm/mach-nomadik/8815.c | 1 + arch/arm/mach-omap/omap4_twl6030_mmc.c | 1 + arch/arm/mach-pxa/gpio.c | 1 + crypto/keystore.c | 1 + drivers/mfd/lp3972.c | 1 + 16 files changed, 19 insertions(+) (limited to 'drivers') diff --git a/arch/arm/boards/crystalfontz-cfa10036/hwdetect.c b/arch/arm/boards/crystalfontz-cfa10036/hwdetect.c index c94cb355e2..e4ccbdb2a3 100644 --- a/arch/arm/boards/crystalfontz-cfa10036/hwdetect.c +++ b/arch/arm/boards/crystalfontz-cfa10036/hwdetect.c @@ -26,6 +26,8 @@ #include +#include "hwdetect.h" + enum board_type { BOARD_ID_CFA10036 = 0, BOARD_ID_CFA10037 = 1, diff --git a/arch/arm/boards/friendlyarm-tiny6410/tiny6410.c b/arch/arm/boards/friendlyarm-tiny6410/tiny6410.c index e066a43dbe..39179c83d8 100644 --- a/arch/arm/boards/friendlyarm-tiny6410/tiny6410.c +++ b/arch/arm/boards/friendlyarm-tiny6410/tiny6410.c @@ -21,6 +21,8 @@ #include #include +#include "tiny6410.h" + static const unsigned tiny6410_pin_usage[] = { /* UART0 */ GPA2_GPIO | GPIO_IN | ENABLE_PU, /* CTS not connected */ diff --git a/arch/arm/lib32/semihosting.c b/arch/arm/lib32/semihosting.c index 10ee7d3640..9fc3b6b62c 100644 --- a/arch/arm/lib32/semihosting.c +++ b/arch/arm/lib32/semihosting.c @@ -21,6 +21,7 @@ #include #include #include +#include #ifndef O_BINARY #define O_BINARY 0 diff --git a/arch/arm/mach-clps711x/devices.c b/arch/arm/mach-clps711x/devices.c index 69574317bd..8eacc70018 100644 --- a/arch/arm/mach-clps711x/devices.c +++ b/arch/arm/mach-clps711x/devices.c @@ -15,6 +15,7 @@ #include #include +#include static int clps711x_mem_init(void) { diff --git a/arch/arm/mach-ep93xx/gpio.c b/arch/arm/mach-ep93xx/gpio.c index 0c87152032..20477f83e6 100644 --- a/arch/arm/mach-ep93xx/gpio.c +++ b/arch/arm/mach-ep93xx/gpio.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #define EP93XX_GPIO_NUM_PORTS 8 diff --git a/arch/arm/mach-ep93xx/led.c b/arch/arm/mach-ep93xx/led.c index a415bce0d7..47e24cd6ed 100644 --- a/arch/arm/mach-ep93xx/led.c +++ b/arch/arm/mach-ep93xx/led.c @@ -20,6 +20,8 @@ #include #include +#include "led.h" + #define GREEN_LED_POS 0x01 #define RED_LED_POS 0x02 diff --git a/arch/arm/mach-mvebu/common.c b/arch/arm/mach-mvebu/common.c index 83aeb41ae2..6b4fa8b889 100644 --- a/arch/arm/mach-mvebu/common.c +++ b/arch/arm/mach-mvebu/common.c @@ -25,6 +25,7 @@ #include #include #include +#include /* * The different SoC headers containing register definitions (mach/dove-regs.h, diff --git a/arch/arm/mach-mxs/power.c b/arch/arm/mach-mxs/power.c index 74c5479f3e..6febf5dbaa 100644 --- a/arch/arm/mach-mxs/power.c +++ b/arch/arm/mach-mxs/power.c @@ -14,6 +14,7 @@ #include #include #include +#include #define POWER_CTRL (IMX_POWER_BASE + 0x0) #define POWER_CTRL_CLKGATE 0x40000000 diff --git a/arch/arm/mach-mxs/usb-imx23.c b/arch/arm/mach-mxs/usb-imx23.c index e626396f9d..d9a54b66f8 100644 --- a/arch/arm/mach-mxs/usb-imx23.c +++ b/arch/arm/mach-mxs/usb-imx23.c @@ -17,6 +17,7 @@ #include #include #include +#include #define USBPHY_PWD (IMX_USBPHY_BASE + 0x0) diff --git a/arch/arm/mach-mxs/usb-imx28.c b/arch/arm/mach-mxs/usb-imx28.c index a87d4f6cbc..a4e1bdb280 100644 --- a/arch/arm/mach-mxs/usb-imx28.c +++ b/arch/arm/mach-mxs/usb-imx28.c @@ -18,6 +18,7 @@ #include #include #include +#include #define POWER_CTRL (IMX_POWER_BASE + 0x0) #define POWER_CTRL_CLKGATE 0x40000000 diff --git a/arch/arm/mach-netx/generic.c b/arch/arm/mach-netx/generic.c index e818f97013..450226d2cc 100644 --- a/arch/arm/mach-netx/generic.c +++ b/arch/arm/mach-netx/generic.c @@ -20,6 +20,7 @@ #include #include #include +#include #include "eth_firmware.h" struct fw_header { diff --git a/arch/arm/mach-nomadik/8815.c b/arch/arm/mach-nomadik/8815.c index dc1bcd2bcd..9f9c0342b4 100644 --- a/arch/arm/mach-nomadik/8815.c +++ b/arch/arm/mach-nomadik/8815.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include diff --git a/arch/arm/mach-omap/omap4_twl6030_mmc.c b/arch/arm/mach-omap/omap4_twl6030_mmc.c index 155add6ea1..67a9a5d6b5 100644 --- a/arch/arm/mach-omap/omap4_twl6030_mmc.c +++ b/arch/arm/mach-omap/omap4_twl6030_mmc.c @@ -17,6 +17,7 @@ #include #include +#include /* MMC voltage */ #define OMAP4_CONTROL_PBIASLITE 0x4A100600 diff --git a/arch/arm/mach-pxa/gpio.c b/arch/arm/mach-pxa/gpio.c index 7dd6ac0648..ebda6bbe2a 100644 --- a/arch/arm/mach-pxa/gpio.c +++ b/arch/arm/mach-pxa/gpio.c @@ -12,6 +12,7 @@ #include #include +#include #include #include diff --git a/crypto/keystore.c b/crypto/keystore.c index f2b25ca6c9..1ce6332979 100644 --- a/crypto/keystore.c +++ b/crypto/keystore.c @@ -9,6 +9,7 @@ #include #include #include +#include static LIST_HEAD(keystore_list); diff --git a/drivers/mfd/lp3972.c b/drivers/mfd/lp3972.c index 3ae9d1ac64..ca736710b2 100644 --- a/drivers/mfd/lp3972.c +++ b/drivers/mfd/lp3972.c @@ -20,6 +20,7 @@ #include #include #include +#include #include -- cgit v1.2.3 From 34b9e71708f71d69a087eb2209445f16fd831218 Mon Sep 17 00:00:00 2001 From: Sascha Hauer Date: Fri, 15 Mar 2019 08:05:29 +0100 Subject: bus: mvebu-mbus: Add missing whitespace orion5x_2win_mbus_data__maybe_unused should be two words. Fix it. Signed-off-by: Sascha Hauer --- drivers/bus/mvebu-mbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers') diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c index 965a221d3b..4b7edb53ed 100644 --- a/drivers/bus/mvebu-mbus.c +++ b/drivers/bus/mvebu-mbus.c @@ -436,7 +436,7 @@ orion5x_4win_mbus_data __maybe_unused = { }; static const struct mvebu_mbus_soc_data -orion5x_2win_mbus_data__maybe_unused = { +orion5x_2win_mbus_data __maybe_unused = { .num_wins = 8, .num_remappable_wins = 2, .win_cfg_offset = orion5x_mbus_win_offset, -- cgit v1.2.3