From 09d11c546738a00754c9f1a9b726ddd14f5b5b38 Mon Sep 17 00:00:00 2001 From: Ahmad Fatoum Date: Mon, 2 Mar 2020 12:49:53 +0100 Subject: video/ssd1307fb: fix NULL pointer dereference in probe info->priv is dereferenced before a valid value has been set leading to a NULL pointer dereference in the probe function. Fix this. Signed-off-by: Ahmad Fatoum Signed-off-by: Sascha Hauer --- drivers/video/ssd1307fb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'drivers') diff --git a/drivers/video/ssd1307fb.c b/drivers/video/ssd1307fb.c index 70077e43a8..83a561a3e1 100644 --- a/drivers/video/ssd1307fb.c +++ b/drivers/video/ssd1307fb.c @@ -405,8 +405,9 @@ static int ssd1307fb_probe(struct device_d *dev) } info = xzalloc(sizeof(struct fb_info)); + par = xzalloc(sizeof(*par)); - par = info->priv; + info->priv = par; par->info = info; par->client = client; @@ -574,6 +575,7 @@ reset_oled_error: free(vmem); fb_alloc_error: regulator_disable(par->vbat); + free(par); free(info); return ret; } -- cgit v1.2.3