From 18a3a7a70976e403b801328891c76437ca6accae Mon Sep 17 00:00:00 2001 From: Peter Mamonov Date: Thu, 12 Mar 2020 23:39:57 +0300 Subject: pinctrl-single: fix parsing of `pinctrl-single,bits` property According to dts/Bindings/pinctrl/pinctrl-single.txt:113 the correct order of parameters is . Fixes: f7e0cae43 ('pinctrl-single: Handle "pinctrl-single,function-mask" dt property') Signed-off-by: Peter Mamonov Signed-off-by: Sascha Hauer --- drivers/pinctrl/pinctrl-single.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers') diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index d4f411b4ad..2cd58df931 100644 --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c @@ -87,8 +87,8 @@ static int pcs_set_state(struct pinctrl_device *pdev, struct device_node *np) for (i = 0; i < rows; i++) { offset = be32_to_cpup(mux + index++); - mask = be32_to_cpup(mux + index++); val = be32_to_cpup(mux + index++); + mask = be32_to_cpup(mux + index++); reg = pcs->read(pcs->base + offset); reg &= ~mask; reg |= val; -- cgit v1.2.3