From e10efc50805672b426f9cdcf4e72a1ba1bd89a8b Mon Sep 17 00:00:00 2001 From: Peter Mamonov Date: Wed, 13 Jun 2018 19:17:55 +0300 Subject: fs: fix memory access via /dev/mem for MIPS64 lseek checks for non-negative in-memory offsets (addresses), failing otherwise. However negative address 0xffffffffXXXXXXXX is a valid MIPS64 virtual address. Signed-off-by: Peter Mamonov Signed-off-by: Sascha Hauer --- fs/fs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'fs/fs.c') diff --git a/fs/fs.c b/fs/fs.c index b66cc9b178..8a49e32b5c 100644 --- a/fs/fs.c +++ b/fs/fs.c @@ -962,7 +962,7 @@ loff_t lseek(int fildes, loff_t offset, int whence) case SEEK_SET: if (f->size != FILE_SIZE_STREAM && offset > f->size) goto out; - if (offset < 0) + if (IS_ERR_VALUE(offset)) goto out; pos = offset; break; @@ -981,7 +981,7 @@ loff_t lseek(int fildes, loff_t offset, int whence) } pos = fsdrv->lseek(&f->fsdev->dev, f, pos); - if (pos < 0) { + if (IS_ERR_VALUE(pos)) { errno = -pos; return -1; } -- cgit v1.2.3