From 350bcb29ec09650bbbbf38683abb25610bd22126 Mon Sep 17 00:00:00 2001 From: Ahmad Fatoum Date: Wed, 20 Nov 2019 09:35:36 +0100 Subject: remoteproc: register a device for new remoteproc instances struct rproc has a device_d dev field, but so far it was unregistered. The implementation had a few downsides: - dev_printf prints NULL, because the unique_name of the device is NULL - The name used by firmwareload is the device tree node's name, which might be unnecessarily verbose, e.g. mlahb:m4@10000000.of - All remoteproc devices are given the same (unused) name and index Fix these by registering a device for the remoteproc and using it where appropriate. While at it, allow the remoteproc name to come from a device tree alias as well. This breaks user behavior in that firmwareload now uses the alias or remoteprocN to reference the remoteproc instance. This is probably acceptable as the driver is a very recent addition. Cc: Oleksij Rempel Signed-off-by: Ahmad Fatoum Signed-off-by: Sascha Hauer --- include/linux/remoteproc.h | 1 - 1 file changed, 1 deletion(-) (limited to 'include/linux') diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h index feee9ee4ee..c6264d1c0a 100644 --- a/include/linux/remoteproc.h +++ b/include/linux/remoteproc.h @@ -38,7 +38,6 @@ struct rproc { void *priv; struct rproc_ops *ops; struct device_d dev; - int index; void *fw_buf; size_t fw_buf_ofs; -- cgit v1.2.3