From 4d6d4651bd31a975df1e1bff6a5652c0410c098a Mon Sep 17 00:00:00 2001 From: Robin van der Gracht Date: Thu, 16 Jun 2022 14:50:40 +0200 Subject: lib: parameter: Free previous string value in param_string_set When the parameter has no set function the previous (saved_value) is not freed up on completion. Signed-off-by: Robin van der Gracht Link: https://lore.barebox.org/20220616125040.212193-1-robin@protonic.nl Signed-off-by: Sascha Hauer --- lib/parameter.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'lib') diff --git a/lib/parameter.c b/lib/parameter.c index 2c9da870a4..6642d73b6c 100644 --- a/lib/parameter.c +++ b/lib/parameter.c @@ -262,8 +262,10 @@ static int param_string_set(struct device_d *dev, struct param_d *p, const char strim(value_new); *ps->value = value_new; - if (!ps->set) + if (!ps->set) { + free(value_save); return 0; + } ret = ps->set(p, p->driver_priv); if (ret) { -- cgit v1.2.3