From 3701ed81ec431df96dc17b0143bdc9ffef072a6b Mon Sep 17 00:00:00 2001 From: Sascha Hauer Date: Sat, 17 Oct 2009 09:42:13 +0200 Subject: ping: do not return -1 in command Also, print usage if not enough arguments given. Signed-off-by: Sascha Hauer --- net/ping.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'net/ping.c') diff --git a/net/ping.c b/net/ping.c index 5909c31fe8..e9336b9578 100644 --- a/net/ping.c +++ b/net/ping.c @@ -83,12 +83,9 @@ PingHandler (uchar * pkt, unsigned dest, unsigned src, unsigned len) int do_ping (cmd_tbl_t *cmdtp, int argc, char *argv[]) { - if (argc < 2) - return -1; - - if (string_to_ip(argv[1], &NetPingIP)) { + if (argc < 2 || string_to_ip(argv[1], &NetPingIP)) { printf ("Usage:\n%s\n", cmdtp->usage); - return -1; + return 1; } if (NetLoopInit(PING) < 0) -- cgit v1.2.3