diff options
| author | Coly Li <colyli@suse.de> | 2019-06-28 19:59:26 +0800 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2019-06-28 07:39:14 -0600 |
| commit | 0ae49cb7aa005ed18fe8f4d6ccf73019b78ac7b2 (patch) | |
| tree | 0d52cb5f20121674c63421d43cb8028831c301af /drivers/md/bcache | |
| parent | b387e9b58679c60f5b1e4313939bd4878204fc37 (diff) | |
| download | linux-0-day-0ae49cb7aa005ed18fe8f4d6ccf73019b78ac7b2.tar.gz linux-0-day-0ae49cb7aa005ed18fe8f4d6ccf73019b78ac7b2.tar.xz | |
bcache: fix return value error in bch_journal_read()
When everything is OK in bch_journal_read(), finally the return value
is returned by,
return ret;
which assumes ret will be 0 here. This assumption is wrong when all
journal buckets as are full and filled with valid journal entries. In
such cache the last location referencess read_bucket() sets 'ret' to
1, which means new jset added into jset list. The jset list is list
'journal' in caller run_cache_set().
Return 1 to run_cache_set() means something wrong and the cache set
won't start, but indeed everything is OK.
This patch changes the line at end of bch_journal_read() to directly
return 0 since everything if verything is good. Then a bogus error
is fixed.
Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/md/bcache')
| -rw-r--r-- | drivers/md/bcache/journal.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/bcache/journal.c b/drivers/md/bcache/journal.c index 12dae9348147e..4e5fc05720fc8 100644 --- a/drivers/md/bcache/journal.c +++ b/drivers/md/bcache/journal.c @@ -268,7 +268,7 @@ bsearch: struct journal_replay, list)->j.seq; - return ret; + return 0; #undef read_bucket } |