diff options
| author | Serge Semin <fancer.lancer@gmail.com> | 2017-12-06 17:31:53 +0300 |
|---|---|---|
| committer | Jon Mason <jdmason@kudzu.us> | 2018-01-28 22:17:23 -0500 |
| commit | 417cf39cfea9c680aa7c278c8d8a0ca879cacf0a (patch) | |
| tree | b53d025c691ee2a7c5a12d0a48d19e2640c45f32 /drivers/ntb/hw/idt/ntb_hw_idt.c | |
| parent | b87ab21935d76922362ff98a5a78f16e2e956ead (diff) | |
| download | linux-0-day-417cf39cfea9c680aa7c278c8d8a0ca879cacf0a.tar.gz linux-0-day-417cf39cfea9c680aa7c278c8d8a0ca879cacf0a.tar.xz | |
NTB: Set dma mask and dma coherent mask to NTB devices
The dma_mask and dma_coherent_mask fields of the NTB struct device
weren't initialized in hardware drivers. In fact it should be done
instead of PCIe interface usage, since NTB clients are supposed to
use NTB API and left unaware of real hardware implementation.
In addition to that ntb_device_register() method shouldn't clear
the passed ntb_dev structure, since it dma_mask is initialized
by hardware drivers.
Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Diffstat (limited to 'drivers/ntb/hw/idt/ntb_hw_idt.c')
| -rw-r--r-- | drivers/ntb/hw/idt/ntb_hw_idt.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/ntb/hw/idt/ntb_hw_idt.c b/drivers/ntb/hw/idt/ntb_hw_idt.c index 24040317bb9cc..93d4c9d2a9add 100644 --- a/drivers/ntb/hw/idt/ntb_hw_idt.c +++ b/drivers/ntb/hw/idt/ntb_hw_idt.c @@ -2426,7 +2426,7 @@ static int idt_init_pci(struct idt_ntb_dev *ndev) struct pci_dev *pdev = ndev->ntb.pdev; int ret; - /* Initialize the bit mask of DMA */ + /* Initialize the bit mask of PCI/NTB DMA */ ret = pci_set_dma_mask(pdev, DMA_BIT_MASK(64)); if (ret != 0) { ret = pci_set_dma_mask(pdev, DMA_BIT_MASK(32)); @@ -2447,6 +2447,12 @@ static int idt_init_pci(struct idt_ntb_dev *ndev) dev_warn(&pdev->dev, "Cannot set consistent DMA highmem bit mask\n"); } + ret = dma_coerce_mask_and_coherent(&ndev->ntb.dev, + dma_get_mask(&pdev->dev)); + if (ret != 0) { + dev_err(&pdev->dev, "Failed to set NTB device DMA bit mask\n"); + return ret; + } /* * Enable the device advanced error reporting. It's not critical to |