diff options
| author | Srinivas Kandagatla <srinivas.kandagatla@linaro.org> | 2019-05-22 17:24:43 +0100 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2019-05-27 10:34:12 +0530 |
| commit | 03ecad90d3798be11b033248bbd4bbff4425a1c7 (patch) | |
| tree | 96a116c3d313bc0712e21f41c9f7d55f8bd630d1 /drivers/soundwire | |
| parent | a188339ca5a396acc588e5851ed7e19f66b0ebd9 (diff) | |
| download | linux-0-day-03ecad90d3798be11b033248bbd4bbff4425a1c7.tar.gz linux-0-day-03ecad90d3798be11b033248bbd4bbff4425a1c7.tar.xz | |
soundwire: stream: fix out of boundary access on port properties
Assigning local iterator to array element and using it again for
indexing would cross the array boundary.
Fix this by directly referring array element without using the local
variable.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/soundwire')
| -rw-r--r-- | drivers/soundwire/stream.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c index d01060dbee962..544925ff0b400 100644 --- a/drivers/soundwire/stream.c +++ b/drivers/soundwire/stream.c @@ -1406,9 +1406,7 @@ struct sdw_dpn_prop *sdw_get_slave_dpn_prop(struct sdw_slave *slave, } for (i = 0; i < num_ports; i++) { - dpn_prop = &dpn_prop[i]; - - if (dpn_prop->num == port_num) + if (dpn_prop[i].num == port_num) return &dpn_prop[i]; } |