diff options
| author | David S. Miller <davem@davemloft.net> | 2018-10-14 13:01:20 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-10-14 13:01:20 -0700 |
| commit | 028c99fa912b4ad2174793da97694a9c4b2cd305 (patch) | |
| tree | 43d8bcccc596a098f490c6e244fd0350750d7886 /kernel | |
| parent | bab5c80b211035739997ebd361a679fa85b39465 (diff) | |
| parent | cee271678d0e3177a25d0fcb2fa5e051d48e4262 (diff) | |
| download | linux-0-day-028c99fa912b4ad2174793da97694a9c4b2cd305.tar.gz linux-0-day-028c99fa912b4ad2174793da97694a9c4b2cd305.tar.xz | |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf
Daniel Borkmann says:
====================
pull-request: bpf 2018-10-14
The following pull-request contains BPF updates for your *net* tree.
The main changes are:
1) Fix xsk map update and delete operation to not call synchronize_net()
but to piggy back on SOCK_RCU_FREE for sockets instead as we are not
allowed to sleep under RCU, from Björn.
2) Do not change RLIMIT_MEMLOCK in reuseport_bpf selftest if the process
already has unlimited RLIMIT_MEMLOCK, from Eric.
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/bpf/xskmap.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/kernel/bpf/xskmap.c b/kernel/bpf/xskmap.c index 9f8463afda9c8..47147c9e184dd 100644 --- a/kernel/bpf/xskmap.c +++ b/kernel/bpf/xskmap.c @@ -192,11 +192,8 @@ static int xsk_map_update_elem(struct bpf_map *map, void *key, void *value, sock_hold(sock->sk); old_xs = xchg(&m->xsk_map[i], xs); - if (old_xs) { - /* Make sure we've flushed everything. */ - synchronize_net(); + if (old_xs) sock_put((struct sock *)old_xs); - } sockfd_put(sock); return 0; @@ -212,11 +209,8 @@ static int xsk_map_delete_elem(struct bpf_map *map, void *key) return -EINVAL; old_xs = xchg(&m->xsk_map[k], NULL); - if (old_xs) { - /* Make sure we've flushed everything. */ - synchronize_net(); + if (old_xs) sock_put((struct sock *)old_xs); - } return 0; } |