diff options
| author | Song Muchun <smuchun@gmail.com> | 2018-10-14 19:26:12 +0800 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2018-10-16 09:36:01 +0200 |
| commit | 9845c49cc9bbb317a0bc9e9cf78d8e09d54c9af0 (patch) | |
| tree | 60ad2ff322aa6fef86deffc68288014f557524ad /kernel | |
| parent | baa9be4ffb55876923dc9716abc0a448e510ba30 (diff) | |
| download | linux-0-day-9845c49cc9bbb317a0bc9e9cf78d8e09d54c9af0.tar.gz linux-0-day-9845c49cc9bbb317a0bc9e9cf78d8e09d54c9af0.tar.xz | |
sched/fair: Fix the min_vruntime update logic in dequeue_entity()
The comment and the code around the update_min_vruntime() call in
dequeue_entity() are not in agreement.
From commit:
b60205c7c558 ("sched/fair: Fix min_vruntime tracking")
I think that we want to update min_vruntime when a task is sleeping/migrating.
So, the check is inverted there - fix it.
Signed-off-by: Song Muchun <smuchun@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: b60205c7c558 ("sched/fair: Fix min_vruntime tracking")
Link: http://lkml.kernel.org/r/20181014112612.2614-1-smuchun@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/sched/fair.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index f88e00705b558..908c9cdae2f0c 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -4001,7 +4001,7 @@ dequeue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags) * put back on, and if we advance min_vruntime, we'll be placed back * further than we started -- ie. we'll be penalized. */ - if ((flags & (DEQUEUE_SAVE | DEQUEUE_MOVE)) == DEQUEUE_SAVE) + if ((flags & (DEQUEUE_SAVE | DEQUEUE_MOVE)) != DEQUEUE_SAVE) update_min_vruntime(cfs_rq); } |