diff options
| author | Xin Long <lucien.xin@gmail.com> | 2018-06-05 12:16:58 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-06-05 10:22:45 -0400 |
| commit | 1d88ba1ebb2763aa86172cd7ca05dedbeccc0d35 (patch) | |
| tree | 44f0a1e83cd7fa3d228172240508629d0892c277 /net | |
| parent | 819dd92b9c0bc7bce9097d8c1f14240f471bb386 (diff) | |
| download | linux-0-day-1d88ba1ebb2763aa86172cd7ca05dedbeccc0d35.tar.gz linux-0-day-1d88ba1ebb2763aa86172cd7ca05dedbeccc0d35.tar.xz | |
sctp: not allow transport timeout value less than HZ/5 for hb_timer
syzbot reported a rcu_sched self-detected stall on CPU which is caused
by too small value set on rto_min with SCTP_RTOINFO sockopt. With this
value, hb_timer will get stuck there, as in its timer handler it starts
this timer again with this value, then goes to the timer handler again.
This problem is there since very beginning, and thanks to Eric for the
reproducer shared from a syzbot mail.
This patch fixes it by not allowing sctp_transport_timeout to return a
smaller value than HZ/5 for hb_timer, which is based on TCP's min rto.
Note that it doesn't fix this issue by limiting rto_min, as some users
are still using small rto and no proper value was found for it yet.
Reported-by: syzbot+3dcd59a1f907245f891f@syzkaller.appspotmail.com
Suggested-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/sctp/transport.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sctp/transport.c b/net/sctp/transport.c index 4a95e260b674b..445b7ef61677c 100644 --- a/net/sctp/transport.c +++ b/net/sctp/transport.c @@ -637,7 +637,7 @@ unsigned long sctp_transport_timeout(struct sctp_transport *trans) trans->state != SCTP_PF) timeout += trans->hbinterval; - return timeout; + return max_t(unsigned long, timeout, HZ / 5); } /* Reset transport variables to their initial values */ |