diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2014-11-25 13:44:20 +0100 |
|---|---|---|
| committer | Rob Clark <robdclark@gmail.com> | 2014-12-17 10:59:49 -0500 |
| commit | 5acb07ea802c3a06bbe22cba32fbb8eb97b6b3ae (patch) | |
| tree | 6bbecbe9dd9122d4958955962653ba15e1e8c88f | |
| parent | 264f7d673fad394d8ed6b17fa9c16e2e62fa0c4e (diff) | |
| download | linux-5acb07ea802c3a06bbe22cba32fbb8eb97b6b3ae.tar.gz linux-5acb07ea802c3a06bbe22cba32fbb8eb97b6b3ae.tar.xz | |
drm/msm: Deletion of unnecessary checks before the function call "release_firmware"
The release_firmware() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Rob Clark <robdclark@gmail.com>
| -rw-r--r-- | drivers/gpu/drm/msm/adreno/adreno_gpu.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index aa873048308b..94a5bee69fe7 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -386,9 +386,7 @@ void adreno_gpu_cleanup(struct adreno_gpu *gpu) msm_gem_put_iova(gpu->memptrs_bo, gpu->base.id); drm_gem_object_unreference(gpu->memptrs_bo); } - if (gpu->pm4) - release_firmware(gpu->pm4); - if (gpu->pfp) - release_firmware(gpu->pfp); + release_firmware(gpu->pm4); + release_firmware(gpu->pfp); msm_gpu_cleanup(&gpu->base); } |