diff options
| author | Yu Kuai <yukuai3@huawei.com> | 2021-05-17 16:18:24 +0800 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2021-05-31 09:33:09 +0530 |
| commit | 83eb4868d325b86e18509d0874e911497667cb54 (patch) | |
| tree | 2a15740118d9ac385e7cbe58cebb43311504544d /drivers/dma | |
| parent | 8982d48af36d2562c0f904736b0fc80efc9f2532 (diff) | |
| download | linux-83eb4868d325b86e18509d0874e911497667cb54.tar.gz linux-83eb4868d325b86e18509d0874e911497667cb54.tar.xz | |
dmaengine: stm32-mdma: fix PM reference leak in stm32_mdma_alloc_chan_resourc()
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20210517081826.1564698-2-yukuai3@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/stm32-mdma.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c index 36ba8b43e78d..18cbd1e43c2e 100644 --- a/drivers/dma/stm32-mdma.c +++ b/drivers/dma/stm32-mdma.c @@ -1452,7 +1452,7 @@ static int stm32_mdma_alloc_chan_resources(struct dma_chan *c) return -ENOMEM; } - ret = pm_runtime_get_sync(dmadev->ddev.dev); + ret = pm_runtime_resume_and_get(dmadev->ddev.dev); if (ret < 0) return ret; @@ -1718,7 +1718,7 @@ static int stm32_mdma_pm_suspend(struct device *dev) u32 ccr, id; int ret; - ret = pm_runtime_get_sync(dev); + ret = pm_runtime_resume_and_get(dev); if (ret < 0) return ret; |