diff options
| author | Tom Rix <trix@redhat.com> | 2021-05-07 12:18:19 -0700 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2021-05-27 15:40:34 +0200 |
| commit | 81c8bf9170477d453b24a6bc3300d201d641e645 (patch) | |
| tree | e660ef31d1c8ca2210d3b79ca53c5cff31feb25b /drivers/hid | |
| parent | 31a4cf1d223dc6144d2e7c679cc3a98f84a1607b (diff) | |
| download | linux-81c8bf9170477d453b24a6bc3300d201d641e645.tar.gz linux-81c8bf9170477d453b24a6bc3300d201d641e645.tar.xz | |
HID: logitech-hidpp: initialize level variable
Static analysis reports this representative problem
hid-logitech-hidpp.c:1356:23: warning: Assigned value is
garbage or undefined
hidpp->battery.level = level;
^ ~~~~~
In some cases, 'level' is never set in hidpp20_battery_map_status_voltage()
Since level is not available on all hw, initialize level to unknown.
Fixes: be281368f297 ("hid-logitech-hidpp: read battery voltage from newer devices")
Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
| -rw-r--r-- | drivers/hid/hid-logitech-hidpp.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index d598094dadd0..fee4e54a3ce0 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -1263,6 +1263,7 @@ static int hidpp20_battery_map_status_voltage(u8 data[3], int *voltage, int status; long flags = (long) data[2]; + *level = POWER_SUPPLY_CAPACITY_LEVEL_UNKNOWN; if (flags & 0x80) switch (flags & 0x07) { |