summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/sfc/ef10.c
diff options
context:
space:
mode:
authorEdward Cree <ecree@solarflare.com>2016-12-02 15:51:33 +0000
committerDavid S. Miller <davem@davemloft.net>2016-12-03 16:11:00 -0500
commite01b16a7e217a23eb97e08d0a591735d5aee5efc (patch)
tree9b060200cd2c308fc968c0f03097c7ff22d496d8 /drivers/net/ethernet/sfc/ef10.c
parent816fba3529040d253cef0047bdef850014e746b9 (diff)
downloadlinux-e01b16a7e217a23eb97e08d0a591735d5aee5efc.tar.gz
linux-e01b16a7e217a23eb97e08d0a591735d5aee5efc.tar.xz
sfc: remove EFX_BUG_ON_PARANOID, use EFX_WARN_ON_[ONCE_]PARANOID instead
Logically, EFX_BUG_ON_PARANOID can never be correct. For, BUG_ON should only be used if it is not possible to continue without potential harm; and since the non-DEBUG driver will continue regardless (as the BUG_ON is compiled out), clearly the BUG_ON cannot be needed in the DEBUG driver. So, replace every EFX_BUG_ON_PARANOID with either an EFX_WARN_ON_PARANOID or the newly defined EFX_WARN_ON_ONCE_PARANOID. Signed-off-by: Edward Cree <ecree@solarflare.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sfc/ef10.c')
-rw-r--r--drivers/net/ethernet/sfc/ef10.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
index 0f58ea8147d4..de2947ccc5ad 100644
--- a/drivers/net/ethernet/sfc/ef10.c
+++ b/drivers/net/ethernet/sfc/ef10.c
@@ -2100,7 +2100,7 @@ static int efx_ef10_tx_tso_desc(struct efx_tx_queue *tx_queue,
u32 seqnum;
u32 mss;
- EFX_BUG_ON_PARANOID(tx_queue->tso_version != 2);
+ EFX_WARN_ON_ONCE_PARANOID(tx_queue->tso_version != 2);
mss = skb_shinfo(skb)->gso_size;