diff options
| author | Dan Williams <dan.j.williams@intel.com> | 2019-11-12 17:13:14 -0800 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2019-11-19 09:52:12 -0800 |
| commit | bfd2e9140656a061138ecdc6a5485d5e2a7a3333 (patch) | |
| tree | 30a8befd5e91306de97ece49ddce9be822ff933b /drivers/nvdimm/pfn_devs.c | |
| parent | 153dd28647d63086dc6e1df5ee06fd0a5d6435a5 (diff) | |
| download | linux-bfd2e9140656a061138ecdc6a5485d5e2a7a3333.tar.gz linux-bfd2e9140656a061138ecdc6a5485d5e2a7a3333.tar.xz | |
libnvdimm: Simplify root read-only definition for the 'resource' attribute
Rather than update the permission in ->is_visible() set the permission
directly at declaration time.
Cc: Ira Weiny <ira.weiny@intel.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Link: https://lore.kernel.org/r/157309905534.1582359.13927459228885931097.stgit@dwillia2-desk3.amr.corp.intel.com
Diffstat (limited to 'drivers/nvdimm/pfn_devs.c')
| -rw-r--r-- | drivers/nvdimm/pfn_devs.c | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/drivers/nvdimm/pfn_devs.c b/drivers/nvdimm/pfn_devs.c index 17ceac5b5313..b94f7a7e94b8 100644 --- a/drivers/nvdimm/pfn_devs.c +++ b/drivers/nvdimm/pfn_devs.c @@ -218,7 +218,7 @@ static ssize_t resource_show(struct device *dev, return rc; } -static DEVICE_ATTR_RO(resource); +static DEVICE_ATTR(resource, 0400, resource_show, NULL); static ssize_t size_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -269,16 +269,8 @@ static struct attribute *nd_pfn_attributes[] = { NULL, }; -static umode_t pfn_visible(struct kobject *kobj, struct attribute *a, int n) -{ - if (a == &dev_attr_resource.attr) - return 0400; - return a->mode; -} - static struct attribute_group nd_pfn_attribute_group = { .attrs = nd_pfn_attributes, - .is_visible = pfn_visible, }; const struct attribute_group *nd_pfn_attribute_groups[] = { |