path: root/mm
diff options
authorSteven Rostedt (VMware) <>2017-02-24 14:59:24 -0800
committerLinus Torvalds <>2017-02-24 17:46:56 -0800
commit517663edd6b5d2a822469885994f34e092e2cf9f (patch)
treef7c566f5810e5580084977a21cab72833aaed5ed /mm
parentc137a2757b88658ce61c74b25ff650ecda7f09d8 (diff)
mm/page-writeback.c: place "not" inside of unlikely() statement in wb_domain_writeout_inc()
The likely/unlikely profiler noticed that the unlikely statement in wb_domain_writeout_inc() is constantly wrong. This is due to the "not" (!) being outside the unlikely statement. It is likely that dom->period_time will be set, but unlikely that it wont be. Move the not into the unlikely statement. Link: Signed-off-by: Steven Rostedt (VMware) <> Reviewed-by: Jan Kara <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
Diffstat (limited to 'mm')
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 2164498..ae6e601 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -580,7 +580,7 @@ static void wb_domain_writeout_inc(struct wb_domain *dom,
__fprop_inc_percpu_max(&dom->completions, completions,
/* First event after period switching was turned off? */
- if (!unlikely(dom->period_time)) {
+ if (unlikely(!dom->period_time)) {
* We can race with other __bdi_writeout_inc calls here but
* it does not cause any harm since the resulting time when