diff options
| author | Tong Zhang <ztong0001@gmail.com> | 2021-09-06 18:47:45 -0700 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2021-09-07 07:13:19 +0200 |
| commit | 8491f59e3b130ea8b5116e363d400c42f91544fc (patch) | |
| tree | 424fb3ebc684431f3a526041df675b0a4af2527e /sound | |
| parent | c8b177b6e3a005bd8fb0395a4bc5db3470301c28 (diff) | |
| download | linux-8491f59e3b130ea8b5116e363d400c42f91544fc.tar.gz linux-8491f59e3b130ea8b5116e363d400c42f91544fc.tar.xz | |
ALSA: vx222: fix null-ptr-deref
a recent refactor created a null pointer vx in snd_vx222_probe().
The vx pointer should have been populated in snd_vx222_create() as
suggested in earlier version, otherwise vx->core.ibl.size will throw an
error.
[ 1.298398] BUG: kernel NULL pointer dereference, address: 00000000000001d8
[ 1.316799] RIP: 0010:snd_vx222_probe+0x155/0x290 [snd_vx222]
Fixes: 3bde3359aa16 ("ALSA: vx222: Allocate resources with device-managed APIs")
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Link: https://lore.kernel.org/r/20210907014746.1445278-1-ztong0001@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/pci/vx222/vx222.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/pci/vx222/vx222.c b/sound/pci/vx222/vx222.c index f48cc20b9e8a..468a6a20dc1e 100644 --- a/sound/pci/vx222/vx222.c +++ b/sound/pci/vx222/vx222.c @@ -137,6 +137,7 @@ static int snd_vx222_create(struct snd_card *card, struct pci_dev *pci, } chip->irq = pci->irq; card->sync_irq = chip->irq; + *rchip = vx; return 0; } |