From d4612a10b4c3ca74ec7344080639dfb945442cbf Mon Sep 17 00:00:00 2001 From: Lucas Stach Date: Fri, 20 Nov 2020 21:17:15 +0100 Subject: drm/bridge: samsung-dsim: fix HFP/HBP/HSA disable modes The bits in the DSI mode_flags specify that HFP/HBP/HSA should be disabled/ignored by the controller. This is the same polarity as the bits in the DSIM control register where a set bit instructs the controller to ignore the blanking area, so the inversion in the current code is wrong. Signed-off-by: Lucas Stach --- drivers/gpu/drm/bridge/samsung-dsim.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 42b49546dd00..4f9c54d5cf7a 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -665,11 +665,11 @@ static int samsung_dsim_init_link(struct samsung_dsim *dsi) reg |= DSIM_AUTO_MODE; if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HSE) reg |= DSIM_HSE_MODE; - if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HFP)) + if ((dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HFP)) reg |= DSIM_HFP_MODE; - if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HBP)) + if ((dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HBP)) reg |= DSIM_HBP_MODE; - if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HSA)) + if ((dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HSA)) reg |= DSIM_HSA_MODE; } -- cgit v1.2.3