From: Sascha Hauer Date: Fri, 28 Nov 2014 11:15:18 +0100 Subject: [PATCH] mkfs.ubifs: simplify make_path with xasprintf Signed-off-by: Sascha Hauer Reviewed-by: Daniel Walter Signed-off-by: Marc Kleine-Budde --- mkfs.ubifs/mkfs.ubifs.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/mkfs.ubifs/mkfs.ubifs.c b/mkfs.ubifs/mkfs.ubifs.c index 049219b52cc5..a99c61382304 100644 --- a/mkfs.ubifs/mkfs.ubifs.c +++ b/mkfs.ubifs/mkfs.ubifs.c @@ -227,13 +227,9 @@ static char *make_path(const char *dir, const char *name) { char *s; - s = malloc(strlen(dir) + strlen(name) + 2); - if (!s) - return NULL; - strcpy(s, dir); - if (dir[strlen(dir) - 1] != '/') - strcat(s, "/"); - strcat(s, name); + xasprintf(&s, "%s%s%s", + dir, dir[strlen(dir) - 1] == '/' ? "" : "/", name); + return s; }