From: Michael Olbrich Date: Thu, 11 Nov 2010 06:00:37 +0100 Subject: [PATCH] Revert "kconfig: ignore select of unknown symbol" We have had warnings for a long time about select of unknow symbol but the warnings does not really makes sense since we may select a symbol that is relevant and defined in one arch but not in another arch. And as long as we do not use a common set of Kconfig files for all archs lets just ignore this case. Previously we have used this to find bad uses of select but we need a more relaible method to do so. Signed-off-by: Sam Ravnborg Cc: Roman Zippel This reverts commit 603d49885e023d1f68c627c2a2db599fb40eefec Signed-off-by: Marc Kleine-Budde Signed-off-by: Michael Olbrich --- scripts/kconfig/menu.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c index aed678e8a777..94f95a2456cc 100644 --- a/scripts/kconfig/menu.c +++ b/scripts/kconfig/menu.c @@ -257,9 +257,12 @@ static void sym_check_prop(struct symbol *sym) prop_warn(prop, "config symbol '%s' uses select, but is " "not boolean or tristate", sym->name); - else if (sym2->type != S_UNKNOWN && - sym2->type != S_BOOLEAN && - sym2->type != S_TRISTATE) + else if (sym2->type == S_UNKNOWN) + prop_warn(prop, + "'select' used by config symbol '%s' " + "refers to undefined symbol '%s'", + sym->name, sym2->name); + else if (sym2->type != S_BOOLEAN && sym2->type != S_TRISTATE) prop_warn(prop, "'%s' has wrong type. 'select' only " "accept arguments of boolean and "