From feff33373a9fcee16f3d2607ad3257e2ae557621 Mon Sep 17 00:00:00 2001 From: Fabio Estevam Date: Tue, 3 Jan 2017 17:11:00 -0200 Subject: drm/imx: imx-tve: Make the 'dac' regulator optional Commit deb65870b5d9d ("drm/imx: imx-tve: check the value returned by regulator_set_voltage()") exposes the following probe issue: 63ff0000.tve supply dac not found, using dummy regulator imx-drm display-subsystem: failed to bind 63ff0000.tve (ops imx_tve_ops): -22 When the 'dac' regulator is not passed in the device tree, devm_regulator_get() will return NULL and when regulator_set_voltage() is called it returns an error. Fix the issue by making the 'dac' regulator optional. Fixes: deb65870b5d9d ("drm/imx: imx-tve: check the value returned by regulator_set_voltage()") Cc: # 4.8+ Signed-off-by: Fabio Estevam Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/imx-tve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index 3b602ee33c44..cec0e12ccb67 100644 --- a/drivers/gpu/drm/imx/imx-tve.c +++ b/drivers/gpu/drm/imx/imx-tve.c @@ -619,7 +619,7 @@ static int imx_tve_bind(struct device *dev, struct device *master, void *data) return ret; } - tve->dac_reg = devm_regulator_get(dev, "dac"); + tve->dac_reg = devm_regulator_get_optional(dev, "dac"); if (!IS_ERR(tve->dac_reg)) { ret = regulator_set_voltage(tve->dac_reg, 2750000, 2750000); if (ret) -- cgit v1.2.3