summaryrefslogtreecommitdiffstats
path: root/diffcore-pickaxe.c
diff options
context:
space:
mode:
authorStefan Beller <sbeller@google.com>2018-01-04 14:50:43 -0800
committerJunio C Hamano <gitster@pobox.com>2018-01-04 15:02:40 -0800
commit5e505257f2651647c072f9c61fdc5dd52bbce8b2 (patch)
tree57327f342244e20dbc8d1dc5f6932343eea13de4 /diffcore-pickaxe.c
parent15af58c1adba431c216e2a45fa0d22944560ba02 (diff)
downloadgit-5e505257f2651647c072f9c61fdc5dd52bbce8b2.tar.gz
git-5e505257f2651647c072f9c61fdc5dd52bbce8b2.tar.xz
diff: properly error out when combining multiple pickaxe options
In f506b8e8b5 (git log/diff: add -G<regexp> that greps in the patch text, 2010-08-23) we were hesitant to check if the user requests both -S and -G at the same time. Now that the pickaxe family also offers --find-object, which looks slightly more different than the former two, let's add a check that those are not used at the same time. Signed-off-by: Stefan Beller <sbeller@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'diffcore-pickaxe.c')
-rw-r--r--diffcore-pickaxe.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/diffcore-pickaxe.c b/diffcore-pickaxe.c
index 72bb5a951..239ce5122 100644
--- a/diffcore-pickaxe.c
+++ b/diffcore-pickaxe.c
@@ -251,7 +251,6 @@ void diffcore_pickaxe(struct diff_options *o)
}
}
- /* Might want to warn when both S and G are on; I don't care... */
pickaxe(&diff_queued_diff, o, regexp, kws,
(opts & DIFF_PICKAXE_KIND_G) ? diff_grep : has_changes);