diff options
| author | Junio C Hamano <gitster@pobox.com> | 2018-12-11 14:46:07 +0900 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2018-12-12 17:06:50 +0900 |
| commit | e5a329a279c7ecb5214ccc049ca659aa3ad733cf (patch) | |
| tree | 24287b28bb98ef5b393eef44221c4730e9bac020 /run-command.c | |
| parent | f67b980771b8cda5fc2093aef6dbec5d7210dcab (diff) | |
| download | git-e5a329a279c7ecb5214ccc049ca659aa3ad733cf.tar.gz git-e5a329a279c7ecb5214ccc049ca659aa3ad733cf.tar.xz | |
run-command: report exec failure
In 321fd823 ("run-command: mark path lookup errors with ENOENT",
2018-10-24), we rewrote the logic to execute a command by looking
in the directories on $PATH; as a side effect, a request to run a
command that is not found on $PATH is noticed even before a child
process is forked to execute it.
We however stopped to report an exec failure in such a case by
mistake. Add a logic to report the error unless silent-exec-failure
is requested, to match the original code.
Reported-by: John Passaro <john.a.passaro@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'run-command.c')
| -rw-r--r-- | run-command.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/run-command.c b/run-command.c index d679cc267..e2bc18a08 100644 --- a/run-command.c +++ b/run-command.c @@ -728,6 +728,8 @@ fail_pipe: if (prepare_cmd(&argv, cmd) < 0) { failed_errno = errno; cmd->pid = -1; + if (!cmd->silent_exec_failure) + error_errno("cannot run %s", cmd->argv[0]); goto end_of_spawn; } |