diff options
| author | Junio C Hamano <gitster@pobox.com> | 2014-08-18 14:38:45 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-09-15 13:23:28 -0700 |
| commit | 4adf569dea052dac88121d822e11c249986b3398 (patch) | |
| tree | 5394494825d8283628dce7efa1b07320b8db1e25 /send-pack.c | |
| parent | 20a7558f31e44e26ddbb8aa55bfd9316a6b67f82 (diff) | |
| download | git-4adf569dea052dac88121d822e11c249986b3398.tar.gz git-4adf569dea052dac88121d822e11c249986b3398.tar.xz | |
signed push: remove duplicated protocol info
With the interim protocol, we used to send the update commands even
though we already send a signed copy of the same information when
push certificate is in use. Update the send-pack/receive-pack pair
not to do so.
The notable thing on the receive-pack side is that it makes sure
that there is no command sent over the traditional protocol packet
outside the push certificate. Otherwise a pusher can claim to be
pushing one set of ref updates in the signed certificate while
issuing commands to update unrelated refs, and such an update will
evade later audits.
Finally, start documenting the protocol.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'send-pack.c')
| -rw-r--r-- | send-pack.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/send-pack.c b/send-pack.c index d392f5b3a..857beb393 100644 --- a/send-pack.c +++ b/send-pack.c @@ -363,7 +363,7 @@ int send_pack(struct send_pack_args *args, for (ref = remote_refs; ref; ref = ref->next) { char *old_hex, *new_hex; - if (args->dry_run) + if (args->dry_run || args->push_cert) continue; if (!ref_update_to_be_sent(ref, args)) |