diff options
| author | Jeff King <peff@peff.net> | 2013-07-09 20:23:28 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2013-07-09 22:23:11 -0700 |
| commit | 8dd0ee823f1829a3aa228c3c73e31de5c89b5317 (patch) | |
| tree | 7bf188adab924793afdbbc9befa43b3f472c47dd /wt-status.h | |
| parent | eccb614924c9067eeceffa503e4da3683f1c8b6b (diff) | |
| download | git-8dd0ee823f1829a3aa228c3c73e31de5c89b5317.tar.gz git-8dd0ee823f1829a3aa228c3c73e31de5c89b5317.tar.xz | |
wt-status: use "format" function attribute for status_printf
These functions could benefit from the added compile-time
safety of having the compiler check printf arguments.
Unfortunately, we also sometimes pass an empty format string,
which will cause false positives with -Wformat-zero-length.
In this case, that warning is wrong because our function is
not a no-op with an empty format: it may be printing
colorized output along with a trailing newline.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'wt-status.h')
| -rw-r--r-- | wt-status.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/wt-status.h b/wt-status.h index 4121bc208..fb7152e18 100644 --- a/wt-status.h +++ b/wt-status.h @@ -96,9 +96,9 @@ void wt_status_get_state(struct wt_status_state *state, int get_detached_from); void wt_shortstatus_print(struct wt_status *s); void wt_porcelain_print(struct wt_status *s); -void status_printf_ln(struct wt_status *s, const char *color, const char *fmt, ...) - ; -void status_printf(struct wt_status *s, const char *color, const char *fmt, ...) - ; +__attribute__((format (printf, 3, 4))) +void status_printf_ln(struct wt_status *s, const char *color, const char *fmt, ...); +__attribute__((format (printf, 3, 4))) +void status_printf(struct wt_status *s, const char *color, const char *fmt, ...); #endif /* STATUS_H */ |