From a7f8b8ac945b32d00086c6e3d2fe7b0d00924442 Mon Sep 17 00:00:00 2001 From: Torstein Hegge Date: Sat, 13 Apr 2013 17:22:57 +0200 Subject: bisect: Store first bad commit as comment in log file When bisect successfully finds a single revision, the first bad commit should be shown to human readers of 'git bisect log'. This resolves the apparent disconnect between the bisection result and the log when a bug reporter says "I know that the first bad commit is $rev, as you can see from $(git bisect log)". Signed-off-by: Torstein Hegge Signed-off-by: Junio C Hamano --- git-bisect.sh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'git-bisect.sh') diff --git a/git-bisect.sh b/git-bisect.sh index 99efbe884..c58eea7cb 100755 --- a/git-bisect.sh +++ b/git-bisect.sh @@ -311,7 +311,13 @@ bisect_next() { res=$? # Check if we should exit because bisection is finished - test $res -eq 10 && exit 0 + if test $res -eq 10 + then + bad_rev=$(git show-ref --hash --verify refs/bisect/bad) + bad_commit=$(git show-branch $bad_rev) + echo "# first bad commit: $bad_commit" >>"$GIT_DIR/BISECT_LOG" + exit 0 + fi # Check for an error in the bisection process test $res -ne 0 && exit $res -- cgit v1.2.3