| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
|
|
|
|
|
|
|
|
| |
The broken error handling had the effect that no command was ever
executed on the target, with only a message "Unable to write: Success"
in the syslog.
Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
|
|
|
|
| |
Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
|
|
|
|
| |
Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
|
|
|
|
| |
Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
|
|
|
|
| |
Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
|
|
|
|
|
|
|
| |
This changes only whitespace, and adds a vim modeline to pin down the
code style.
Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We support dual-stack usage by unsetting the IPV6_V6ONLY option, so IPv4
clients get mapped to IPv6 (IPv4-Mapped IPv6 Address, RFC 4249, like in
"Connection received from ::ffff:192.168.123.1"). This way we can use
struct sockaddr_in6 throughout the code without the need to
differentiate between sockaddr_in and sockaddr_in6 all the time.
The magic of selecting the right protocol, port, etc. is now done by
getaddrinfo instead of getservbyname. The port parameter of mainloop()
is not used anyway, remove it.
While we're at it, also improve setsockopt error handling.
I'm really not sure about the hunk starting at line 496 ("setsockopt
IP_OPTIONS NULL"). See the comment there, feedback is welcome.
Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When building on GCC 5.4.0 with --enable-debug, -Werror is in effect:
make[2]: Entering directory 'urshd-1.0.2/src'
arm-v7a-linux-gnueabi-gcc -DHAVE_CONFIG_H -I. -I../include -Wall -Wsign-compare -Wfloat-equal -Wformat-security -Werror -g -O1 -MT urshd.o -MD -MP -MF .deps/urshd.Tpo -c -o urshd.o urshd.c
urshd.c: In function 'mainloop':
urshd.c:582:1: error: no return statement in function returning non-void [-Werror=return-type]
urshd.c:541:3: error: ignoring return value of 'daemon', declared with attribute warn_unused_result [-Werror=unused-result]
urshd.c: In function 'doit':
urshd.c:340:3: error: ignoring return value of 'chdir', declared with attribute warn_unused_result [-Werror=unused-result]
urshd.c:352:2: error: ignoring return value of 'write', declared with attribute warn_unused_result [-Werror=unused-result]
urshd.c: In function 'error':
urshd.c:203:5: error: ignoring return value of 'write', declared with attribute warn_unused_result [-Werror=unused-result]
urshd.c: In function 'stderr_parent':
urshd.c:277:3: error: ignoring return value of 'write', declared with attribute warn_unused_result [-Werror=unused-result]
cc1: all warnings being treated as errors
GNUmakefile:231: recipe for target 'urshd.o' failed
make[2]: *** [urshd.o] Error 1
make[2]: Leaving directory 'urshd-1.0.2/src'
Use this opportunity to improve error handling.
Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
|
|
|
|
|
|
|
|
|
| |
-Og builds with minimal optimization, just enough so it does not
obstruct debugging. -ggdb writes debugging symbols in the most verbose
format that gdb can read. Both should result in an improved debugging
experience.
Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
|
|
|
|
| |
Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
|
|
|
|
| |
Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
|
|
|
|
| |
Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
|
|
|
|
| |
Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
|
|
|
|
|
| |
Lindent
|
|
|
|
|
| |
added from netkit-rsh_0.17.orig.tar.gz
|
|
|
|
|
| |
cleanup GNUmakefile.in
|
|
|
|
|
| |
added, from netkit-rsh_0.17.orig.tar.gz
|
|
|
|
|
| |
version bump to 1.0.2
|
|
|
|
|
| |
use sysconf rather than hardcoded value for ARG_MAX
|
|
|
|
|
| |
add daemonisation
|
|
|
|
|
|
| |
ignore SIGCHLD, so no more defunct childrem
cleanups
|
|
|
|
|
| |
cleanups, version bump to 1.0.1
|
| |
|
| |
|
|
|
|
| |
cosmetic changes
|
| |
|
| |
|
| |
|
| |
|
|
|