summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYubo Feng <fengyubo3@huawei.com>2020-07-01 16:19:32 +1000
committerStephen Rothwell <sfr@canb.auug.org.au>2020-07-02 08:37:54 +1000
commit0d3d7210aef2c6f8b90cca51aa2b814ef3da98e8 (patch)
treea7ec169fa32fb60f3fe30c72850cbc0a98b9991d
parent963e43813d8ed1b6fb6a5ac0dac5dd8c944c93cc (diff)
downloadlinux-0d3d7210aef2c6f8b90cca51aa2b814ef3da98e8.tar.gz
linux-0d3d7210aef2c6f8b90cca51aa2b814ef3da98e8.tar.xz
fatfs: switch write_lock to read_lock in fat_ioctl_get_attributes
There is no need to hold write_lock in fat_ioctl_get_attributes. write_lock may make an impact on concurrency of fat_ioctl_get_attributes. Link: http://lkml.kernel.org/r/1593308053-12702-1-git-send-email-fengyubo3@huawei.com Signed-off-by: Yubo Feng <fengyubo3@huawei.com> Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
-rw-r--r--fs/fat/file.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/fat/file.c b/fs/fat/file.c
index 42134c58c87e..f9ee27cf4d7c 100644
--- a/fs/fat/file.c
+++ b/fs/fat/file.c
@@ -25,9 +25,9 @@ static int fat_ioctl_get_attributes(struct inode *inode, u32 __user *user_attr)
{
u32 attr;
- inode_lock(inode);
+ inode_lock_shared(inode);
attr = fat_make_attrs(inode);
- inode_unlock(inode);
+ inode_unlock_shared(inode);
return put_user(attr, user_attr);
}