diff options
| author | Enrico Scholz <enrico.scholz@sigma-chemnitz.de> | 2024-04-12 18:29:25 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2024-04-16 13:16:13 +0200 |
| commit | 7b7ab4a37d255ef8261e6a33c6e3e488c609e811 (patch) | |
| tree | 26fa34cf8272abc9306cb9b3f3c23b876f2bbbab | |
| parent | 75d6a1ce692d6c0645802e3e96f6c648f29d0c99 (diff) | |
| download | barebox-7b7ab4a37d255ef8261e6a33c6e3e488c609e811.tar.gz barebox-7b7ab4a37d255ef8261e6a33c6e3e488c609e811.tar.xz | |
of: do not acccess 'prop->value' directly
Use of_property_get_value() accessor. Else, wrong results are
returned when working with fit images.
Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Link: https://lore.barebox.org/20240412162925.284747-1-enrico.scholz@sigma-chemnitz.de
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| -rw-r--r-- | drivers/of/base.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/of/base.c b/drivers/of/base.c index b22959dabe..9bd0cdaac2 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -853,7 +853,7 @@ int of_property_count_elems_of_size(const struct device_node *np, if (!prop) return -EINVAL; - if (!prop->value) + if (!of_property_get_value(prop)) return -ENODATA; if (prop->length % elem_size != 0) { @@ -2009,9 +2009,9 @@ int of_property_read_string_helper(const struct device_node *np, if (!prop) return -EINVAL; - if (!prop->value) + p = of_property_get_value(prop); + if (!p) return -ENODATA; - p = prop->value; end = p + prop->length; for (i = 0; p < end && (!out_strs || i < skip + sz); i++, p += l) { |