summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRobin van der Gracht <robin@protonic.nl>2022-06-16 14:50:40 +0200
committerSascha Hauer <s.hauer@pengutronix.de>2022-06-16 15:47:22 +0200
commit4d6d4651bd31a975df1e1bff6a5652c0410c098a (patch)
tree110ba6646e43eec1f7fbbb4c002957a160c809d8
parent62074ec3867d8fe6b2e8d1989ae0f547692be727 (diff)
downloadbarebox-4d6d4651bd31a975df1e1bff6a5652c0410c098a.tar.gz
barebox-4d6d4651bd31a975df1e1bff6a5652c0410c098a.tar.xz
lib: parameter: Free previous string value in param_string_set
When the parameter has no set function the previous (saved_value) is not freed up on completion. Signed-off-by: Robin van der Gracht <robin@protonic.nl> Link: https://lore.barebox.org/20220616125040.212193-1-robin@protonic.nl Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
-rw-r--r--lib/parameter.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/parameter.c b/lib/parameter.c
index 2c9da870a4..6642d73b6c 100644
--- a/lib/parameter.c
+++ b/lib/parameter.c
@@ -262,8 +262,10 @@ static int param_string_set(struct device_d *dev, struct param_d *p, const char
strim(value_new);
*ps->value = value_new;
- if (!ps->set)
+ if (!ps->set) {
+ free(value_save);
return 0;
+ }
ret = ps->set(p, p->driver_priv);
if (ret) {