diff options
| author | Ahmad Fatoum <a.fatoum@pengutronix.de> | 2024-03-13 11:00:48 +0100 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2024-03-13 12:38:33 +0100 |
| commit | 50cbfd91b5737dedc6d1713f0cbacb67c1a604b1 (patch) | |
| tree | 748a1480566cb8091492e57c52530801cfefd324 | |
| parent | 3c8d123593cc7ad4070dc9f0631bd30d1d733225 (diff) | |
| download | barebox-50cbfd91b573.tar.gz barebox-50cbfd91b573.tar.xz | |
console: flush consoles on newline when debugging
For debugging hangs, CONFIG_DEBUG_PROBES and CONFIG_DEBUG_INITCALLS are
useful tools to pinpoint where the issue is. FOr issues that lock up the
SoC, their output can be misleading if we have bigger UART FIFO and not
all output has managed to make it out.
Add a new DEBUG_FLUSH_LINE_BREAK to make debugging this easier.
The option is unnecessary outside of debugging, so for now we don't add
a prompt by default and select it as needed.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Link: https://lore.barebox.org/20240313100048.386604-1-a.fatoum@pengutronix.de
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| -rw-r--r-- | common/Kconfig | 12 | ||||
| -rw-r--r-- | common/console.c | 5 |
2 files changed, 16 insertions, 1 deletions
diff --git a/common/Kconfig b/common/Kconfig index d16c8696da..92556fb910 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -813,6 +813,16 @@ config CONSOLE_ALLOW_COLOR compile time default for colored console output. After boot it can be controlled using global.allow_color. +config CONSOLE_FLUSH_LINE_BREAK + bool "Flush consoles on new line" if COMPILE_TEST + help + Many serial drivers configure and use hardware FIFOs as not to + delay the boot. When debuging some king of bugs, such as clock + issues that hang the SoC, this can falsify debugging output, + because the UART doesn't output a submitted message fully, before + the SoC hangs. This option will flush serial FIFOs when processing + the new line feed characters. + config CONSOLE_DISABLE_INPUT prompt "Disable input on all consoles by default (non-interactive)" def_bool CONSOLE_NONE @@ -1678,6 +1688,7 @@ config DEBUG_AT91_UART_BASE config DEBUG_INITCALLS bool "Trace initcalls" + select CONSOLE_FLUSH_LINE_BREAK help If enabled this will print initcall traces. @@ -1692,6 +1703,7 @@ config DEBUG_PBL config DEBUG_PROBES bool "Trace driver probes/removes" + select CONSOLE_FLUSH_LINE_BREAK help If enabled this will log driver probe and remove traces. If DEBUG_LL is enabled, probes will be printed even before registering consoles. If it's disabled, they diff --git a/common/console.c b/common/console.c index 03b76b122b..5a0fd66ab3 100644 --- a/common/console.c +++ b/common/console.c @@ -277,8 +277,11 @@ static int __console_puts(struct console_device *cdev, const char *s, size_t i; for (i = 0; i < nbytes; i++) { - if (*s == '\n') + if (*s == '\n') { cdev->putc(cdev, '\r'); + if (IS_ENABLED(CONFIG_CONSOLE_FLUSH_LINE_BREAK) && cdev->flush) + cdev->flush(cdev); + } cdev->putc(cdev, *s); s++; |