diff options
| author | Sascha Hauer <s.hauer@pengutronix.de> | 2024-02-21 15:27:59 +0100 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2024-02-23 08:28:39 +0100 |
| commit | ff5e5b69d643793a711ca4a85d3bf97c448817a1 (patch) | |
| tree | 657678c86d4263c61240e7d0d20f4b349c29524e | |
| parent | 73b7973cee7d832b7d2205c0dbeda9fa4c0676f9 (diff) | |
| download | barebox-ff5e5b69d643793a711ca4a85d3bf97c448817a1.tar.gz barebox-ff5e5b69d643793a711ca4a85d3bf97c448817a1.tar.xz | |
input: gpio_keys: limit poll rate
GPIOs a sometimes slow to read out, for example when they are provided
by I2C GPIO expanders. Limit the poll rate so that we do not slow down
barebox more than necessary in these cases.
Link: https://lore.barebox.org/20240221142800.1958810-4-s.hauer@pengutronix.de
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| -rw-r--r-- | drivers/input/gpio_keys.c | 20 |
1 files changed, 8 insertions, 12 deletions
diff --git a/drivers/input/gpio_keys.c b/drivers/input/gpio_keys.c index 77013be133..fd3995d01f 100644 --- a/drivers/input/gpio_keys.c +++ b/drivers/input/gpio_keys.c @@ -29,20 +29,14 @@ struct gpio_keys { struct gpio_key *buttons; int nbuttons; - struct poller_struct poller; + struct poller_async poller; struct input_device input; struct device *dev; }; -static inline struct gpio_keys * -poller_to_gk_pdata(struct poller_struct *poller) +static void gpio_key_poller(void *data) { - return container_of(poller, struct gpio_keys, poller); -} - -static void gpio_key_poller(struct poller_struct *poller) -{ - struct gpio_keys *gk = poller_to_gk_pdata(poller); + struct gpio_keys *gk = data; struct gpio_key *gb; int i, val; @@ -64,6 +58,8 @@ static void gpio_key_poller(struct poller_struct *poller) gb->previous_state = val; } } + + poller_call_async(&gk->poller, 10 * MSECOND, gpio_key_poller, gk); } static int gpio_keys_probe_pdata(struct gpio_keys *gk, struct device *dev) @@ -159,16 +155,16 @@ static int __init gpio_keys_probe(struct device *dev) gk->buttons[i].previous_state = gk->buttons[i].active_low; } - gk->poller.func = gpio_key_poller; - ret = input_device_register(&gk->input); if (ret) return ret; - ret = poller_register(&gk->poller, dev_name(dev)); + ret = poller_async_register(&gk->poller, dev_name(dev)); if (ret) return ret; + poller_call_async(&gk->poller, 10 * MSECOND, gpio_key_poller, gk); + return 0; } |