diff options
| author | Ahmad Fatoum <a.fatoum@pengutronix.de> | 2023-06-05 08:29:35 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2023-06-06 11:34:33 +0200 |
| commit | 810b59f44103063ecc62153878b580f531b44faf (patch) | |
| tree | 39ad21fe83f626b81b796d6718bb6131704d32fe /arch/powerpc | |
| parent | bf17cddb30eefc6b1f5b93ffdfc7bbb573534117 (diff) | |
| download | barebox-810b59f44103063ecc62153878b580f531b44faf.tar.gz barebox-810b59f44103063ecc62153878b580f531b44faf.tar.xz | |
net: fec_mpc5200: fix false positive -Wmisleading-indentation
After the preprocessor runs, the code in question looks like this:
SDMA_INT_DISABLE
while ((counter--) && (!(fec->eth->ievent & FEC_IEVENT_GRA)));
{
struct mpc5xxx_sdma *sdma = (struct mpc5xxx_sdma *)MPC5XXX_SDMA;
sdma->IntMask |= (1 << tasknum);
}
Which understandably looks like a bug. Avoid this by using do { } while
(0) and moving the semicolon to a separate line.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Link: https://lore.barebox.org/20230605062939.242063-3-a.fatoum@pengutronix.de
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'arch/powerpc')
| -rw-r--r-- | arch/powerpc/mach-mpc5xxx/include/mach/sdma.h | 25 |
1 files changed, 10 insertions, 15 deletions
diff --git a/arch/powerpc/mach-mpc5xxx/include/mach/sdma.h b/arch/powerpc/mach-mpc5xxx/include/mach/sdma.h index 02f561675a..176ed3e892 100644 --- a/arch/powerpc/mach-mpc5xxx/include/mach/sdma.h +++ b/arch/powerpc/mach-mpc5xxx/include/mach/sdma.h @@ -49,40 +49,35 @@ ALL PARAMETERS ARE ALL LONGWORDS (FOUR BYTES EACH). /*---------------------------------------------------------------------*/ /* Disable SmartDMA task */ -#define SDMA_TASK_DISABLE(tasknum) \ -{ \ +#define SDMA_TASK_DISABLE(tasknum) do { \ volatile ushort *tcr = (ushort *)(MPC5XXX_SDMA + 0x0000001c + 2 * tasknum); \ *tcr = (*tcr) & (~0x8000); \ -} +} while (0) /* Enable SmartDMA task */ -#define SDMA_TASK_ENABLE(tasknum) \ -{ \ +#define SDMA_TASK_ENABLE(tasknum) do { \ volatile ushort *tcr = (ushort *) (MPC5XXX_SDMA + 0x0000001c + 2 * tasknum); \ *tcr = (*tcr) | 0x8000; \ -} +} while (0) /* Enable interrupt */ -#define SDMA_INT_ENABLE(tasknum) \ -{ \ +#define SDMA_INT_ENABLE(tasknum) do { \ struct mpc5xxx_sdma *sdma = (struct mpc5xxx_sdma *)MPC5XXX_SDMA; \ sdma->IntMask &= ~(1 << tasknum); \ -} +} while (0) /* Disable interrupt */ -#define SDMA_INT_DISABLE(tasknum) \ -{ \ +#define SDMA_INT_DISABLE(tasknum) do { \ struct mpc5xxx_sdma *sdma = (struct mpc5xxx_sdma *)MPC5XXX_SDMA; \ sdma->IntMask |= (1 << tasknum); \ -} +} while (0) /* Clear interrupt pending bits */ -#define SDMA_CLEAR_IEVENT(tasknum) \ -{ \ +#define SDMA_CLEAR_IEVENT(tasknum) do { \ struct mpc5xxx_sdma *sdma = (struct mpc5xxx_sdma *)MPC5XXX_SDMA; \ sdma->IntPend = (1 << tasknum); \ -} +} while (0) /* get interrupt pending bit of a task */ #define SDMA_GET_PENDINGBIT(tasknum) \ |