summaryrefslogtreecommitdiffstats
path: root/commands/go.c
diff options
context:
space:
mode:
authorTrent Piepho <tpiepho@kymetacorp.com>2015-12-04 19:24:19 +0000
committerSascha Hauer <s.hauer@pengutronix.de>2015-12-07 10:44:45 +0100
commita2b3a25417593e97500cd746f0632d36edfac1a5 (patch)
treed7fdf1cb8319d51f8b3b0f259d56621a211e2282 /commands/go.c
parentde7a09bb4326fd9f014303a45e3ad5a729ac3a3c (diff)
downloadbarebox-a2b3a25417593e97500cd746f0632d36edfac1a5.tar.gz
barebox-a2b3a25417593e97500cd746f0632d36edfac1a5.tar.xz
ARM: Remove do_execute and thumb2_execute
In commit 104a6a7ccfb7928ca5dc28c8cbe0ea231ffc45ee support was added for Thumb2. It added do_execute() as a way to provide arch dependent calling veneers for use in "go" and thumb2_execute() as the thumb2 to arm veneer. But thumb2_execute() isn't necessary as gcc generates a proper calling sequence from a standard function pointer call. Thumb2 barebox is compiled with the AAPCS ABI which requires this. It also had a bug and didn't pass the arguments properly, but code execute via "go" rarely uses arguments so this wasn't very noticeable. Since thumb2 was always the only user of do_execute(), go ahead and delete that too. Signed-off-by: Trent Piepho <tpiepho@kymetacorp.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'commands/go.c')
-rw-r--r--commands/go.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/commands/go.c b/commands/go.c
index f25db48ca2..fb319b320c 100644
--- a/commands/go.c
+++ b/commands/go.c
@@ -60,10 +60,7 @@ static int do_go(int argc, char *argv[])
shutdown_barebox();
- if (do_execute)
- do_execute(func, argc - 1, &argv[1]);
- else
- func(argc - 1, &argv[1]);
+ func(argc - 1, &argv[1]);
/*
* The application returned. Since we have shutdown barebox and