summaryrefslogtreecommitdiffstats
path: root/commands/help.c
diff options
context:
space:
mode:
authorEnrico Jorns <ejo@pengutronix.de>2016-09-12 12:20:56 +0200
committerSascha Hauer <s.hauer@pengutronix.de>2016-09-16 09:36:26 +0200
commit9cd9d98300af3039db7f146a47914baef2e8ea1b (patch)
tree6919f2da2e25f64089ffb1771c430f7c341e8342 /commands/help.c
parenta38b7017b3d9b16fcc08c5d1ae83cd920a6af699 (diff)
downloadbarebox-9cd9d98300af3039db7f146a47914baef2e8ea1b.tar.gz
commands: exit on invalid option
Barebox commands should not perform any action and return 0 if an invalid parameter was given. This might cause undetected unintended behvaior when calling commands with wrong options, either manually or from a script. Signed-off-by: Enrico Jorns <ejo@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'commands/help.c')
-rw-r--r--commands/help.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/commands/help.c b/commands/help.c
index 3d36d9b..819c406 100644
--- a/commands/help.c
+++ b/commands/help.c
@@ -98,6 +98,8 @@ static int do_help(int argc, char *argv[])
case 'a':
all = 1;
break;
+ default:
+ return COMMAND_ERROR_USAGE;
}
}