summaryrefslogtreecommitdiffstats
path: root/common/firmware.c
diff options
context:
space:
mode:
authorDenis Orlov <denorl2009@gmail.com>2023-01-13 17:06:48 +0300
committerSascha Hauer <s.hauer@pengutronix.de>2023-01-16 13:40:38 +0100
commitefae55f80b6e6df0a1d3516ff3ddd688d1035169 (patch)
treeacac418869aa57e0dfd9d160accef6c89d605e45 /common/firmware.c
parent31e5e23730ea2459d4d370596a43a8c8b4bf8758 (diff)
downloadbarebox-efae55f80b6e6df0a1d3516ff3ddd688d1035169.tar.gz
barebox-efae55f80b6e6df0a1d3516ff3ddd688d1035169.tar.xz
ddr_spd: use unsigned type for crc bytes in DDR3/4 SPD check
Using signed char type for computed CRC bytes leads to them being sign extended on comparison with unsigned char values from SPD EEPROM struct. This happens as when being compared those values undergo integer promotion that converts them into ints, sign extending signed types. Having most significant byte set for any of computed CRC bytes thus results in the mismatch being erroneously detected. While at it, also remove redundant type casts. Signed-off-by: Denis Orlov <denorl2009@gmail.com> Link: https://lore.barebox.org/20230113140648.31572-1-denorl2009@gmail.com Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'common/firmware.c')
0 files changed, 0 insertions, 0 deletions