diff options
author | Denis Orlov <denorl2009@gmail.com> | 2023-01-13 17:06:48 +0300 |
---|---|---|
committer | Sascha Hauer <s.hauer@pengutronix.de> | 2023-01-16 13:40:38 +0100 |
commit | efae55f80b6e6df0a1d3516ff3ddd688d1035169 (patch) | |
tree | acac418869aa57e0dfd9d160accef6c89d605e45 /common/memtest.c | |
parent | 31e5e23730ea2459d4d370596a43a8c8b4bf8758 (diff) | |
download | barebox-efae55f80b6e6df0a1d3516ff3ddd688d1035169.tar.gz barebox-efae55f80b6e6df0a1d3516ff3ddd688d1035169.tar.xz |
ddr_spd: use unsigned type for crc bytes in DDR3/4 SPD check
Using signed char type for computed CRC bytes leads to them being sign
extended on comparison with unsigned char values from SPD EEPROM struct.
This happens as when being compared those values undergo integer
promotion that converts them into ints, sign extending signed types.
Having most significant byte set for any of computed CRC bytes thus
results in the mismatch being erroneously detected.
While at it, also remove redundant type casts.
Signed-off-by: Denis Orlov <denorl2009@gmail.com>
Link: https://lore.barebox.org/20230113140648.31572-1-denorl2009@gmail.com
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'common/memtest.c')
0 files changed, 0 insertions, 0 deletions