summaryrefslogtreecommitdiffstats
path: root/common
diff options
context:
space:
mode:
authorSascha Hauer <s.hauer@pengutronix.de>2018-11-29 11:17:08 +0100
committerSascha Hauer <s.hauer@pengutronix.de>2018-11-29 15:04:31 +0100
commit4b48ae4bcdbc137c80b77adc5aa614e5f4cb9f51 (patch)
treeec502443c6dd7e665a8b420d49eb5ae811de7775 /common
parentcd9a7567b0d5afd874dcd31fd22918868e9eab9e (diff)
downloadbarebox-4b48ae4bcdbc137c80b77adc5aa614e5f4cb9f51.tar.gz
net: dns: return error codes
The resolv() function used to return the IP address. When net_udp_new() fails we return an error code though which the callers of resolv() take as an IP address. This is wrong of course and we could return 0 in this case. Instead we return an error code and pass the resolved IP as a pointer which allows us to return proper error codes. This patch also adds error messages and error returns to the various callers of resolv() which used to just continue with a zero IP and let the user figure out what went wrong. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'common')
-rw-r--r--common/blspec.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/common/blspec.c b/common/blspec.c
index 2c682e1..41f2a4c 100644
--- a/common/blspec.c
+++ b/common/blspec.c
@@ -303,9 +303,11 @@ static char *parse_nfs_url(const char *url)
goto out;
}
- ip = resolv(host);
- if (ip == 0)
+ ret = resolv(host, &ip);
+ if (ret) {
+ pr_err("Cannot resolve \"%s\": %s\n", host, strerror(-ret));
goto out;
+ }
hostpath = basprintf("%pI4:%s", &ip, path);