diff options
| author | Eric Bénard <eric@eukrea.com> | 2013-04-11 14:04:51 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2013-04-12 19:26:47 +0200 |
| commit | 59dbb4fe2c70fc79497f486c55c5fa785299b1c1 (patch) | |
| tree | a3e985b6c8febd822a4edf0c86396747127170d0 /drivers/mtd/mtdraw.c | |
| parent | 8474cc900f96d306b5ac7733fc4aebf702a942a0 (diff) | |
| download | barebox-59dbb4fe2c70fc79497f486c55c5fa785299b1c1.tar.gz barebox-59dbb4fe2c70fc79497f486c55c5fa785299b1c1.tar.xz | |
mtdraw: fix oob read and write
actually ops.ooboffs is not defaulted so when its value gets
added to chip->oob_poi in nand_fill_oob or nand_transfer_oob
the respective memcpy is using a wrong address.
With this patch, both md -s /dev/nandraw0 and cp xyz /dev/nandraw0.sb
are working fine on an i.MX28 target (instead of crashing the board).
Signed-off-by: Eric Bénard <eric@eukrea.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers/mtd/mtdraw.c')
| -rw-r--r-- | drivers/mtd/mtdraw.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/mtd/mtdraw.c b/drivers/mtd/mtdraw.c index 384104ec27..c289e8d48e 100644 --- a/drivers/mtd/mtdraw.c +++ b/drivers/mtd/mtdraw.c @@ -98,6 +98,7 @@ static ssize_t mtdraw_read_unaligned(struct mtd_info *mtd, void *dst, if (!tmp) return -ENOMEM; ops.mode = MTD_OOB_RAW; + ops.ooboffs = 0; ops.datbuf = tmp; ops.len = mtd->writesize; ops.oobbuf = tmp + mtd->writesize; @@ -152,6 +153,7 @@ static ssize_t mtdraw_blkwrite(struct mtd_info *mtd, const void *buf, int ret; ops.mode = MTD_OOB_RAW; + ops.ooboffs = 0; ops.datbuf = (void *)buf; ops.len = mtd->writesize; ops.oobbuf = (void *)buf + mtd->writesize; |