diff options
| author | Richard Weinberger <richard@nod.at> | 2018-08-29 14:19:19 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2018-08-31 08:23:29 +0200 |
| commit | 9afa745978784721bbddeaafc5e679fe7ca876a7 (patch) | |
| tree | 6b5703ca28a55bbe5bf6eea7635d5f27288a4a2c /drivers/mtd/ubi/eba.c | |
| parent | 754de844abcf5210bd09234adf679dd6465bf230 (diff) | |
| download | barebox-9afa745978784721bbddeaafc5e679fe7ca876a7.tar.gz barebox-9afa745978784721bbddeaafc5e679fe7ca876a7.tar.xz | |
UBI: Don't read back all data in ubi_eba_copy_leb()
Drop this paranoia check from the old days.
If our MTD driver or the flash is so bad that we even cannot
trust it to write data we have bigger problems.
If one really does not trust the flash and wants write-verify
she can enable UBI io checks using debugfs.
Signed-off-by: Richard Weinberger <richard@nod.at>
[Fixed up conflicts due to non exsisting logging in barebox]
Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers/mtd/ubi/eba.c')
| -rw-r--r-- | drivers/mtd/ubi/eba.c | 24 |
1 files changed, 0 insertions, 24 deletions
diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c index 31dbcd29c3..c242c460e8 100644 --- a/drivers/mtd/ubi/eba.c +++ b/drivers/mtd/ubi/eba.c @@ -1077,30 +1077,6 @@ int ubi_eba_copy_leb(struct ubi_device *ubi, int from, int to, err = MOVE_TARGET_WR_ERR; goto out_unlock_buf; } - - /* - * We've written the data and are going to read it back to make - * sure it was written correctly. - */ - memset(ubi->peb_buf, 0xFF, aldata_size); - err = ubi_io_read_data(ubi, ubi->peb_buf, to, 0, aldata_size); - if (err) { - if (err != UBI_IO_BITFLIPS) { - ubi_warn(ubi, "error %d while reading data back from PEB %d", - err, to); - if (is_error_sane(err)) - err = MOVE_TARGET_RD_ERR; - } else - err = MOVE_TARGET_BITFLIPS; - goto out_unlock_buf; - } - - if (crc != crc32(UBI_CRC32_INIT, ubi->peb_buf, data_size)) { - ubi_warn(ubi, "read data back from PEB %d and it is different", - to); - err = -EINVAL; - goto out_unlock_buf; - } } ubi_assert(vol->eba_tbl[lnum] == from); |