diff options
author | Trent Piepho <tpiepho@kymetacorp.com> | 2015-11-11 20:54:01 +0000 |
---|---|---|
committer | Sascha Hauer <s.hauer@pengutronix.de> | 2015-11-13 08:00:19 +0100 |
commit | f0ae0c33f52ced89da080673ca89a3c5f2ea70e6 (patch) | |
tree | 03ae39e6c9d0ee2588aea1b96f4e3b9040ea1640 /drivers/net/rtl8169.c | |
parent | c9a3849ec9f5f7356dd61e7e4bf90e3a55cca1cd (diff) | |
download | barebox-f0ae0c33f52ced89da080673ca89a3c5f2ea70e6.tar.gz barebox-f0ae0c33f52ced89da080673ca89a3c5f2ea70e6.tar.xz |
net: designware: Don't hang in reset with powered down phy
The dw MAC requires that all clock domains to be running for it to
finish a MAC reset. This include the clock provided by the PHY.
If the PHY is powered down, bit BMCR_PDOWN set, then it won't be
generating a clock. And so the MAC never comes out of reset. On
shutdown, Linux will put the PHY in powerdown mode, so it can easily
be the case that the PHY is powered down on boot.
See Linux kernel commit 2d871aa07136fe6e576bde63072cf33e2c664e95.
Currently the MAC reset is done before the phy is probed. We can't
power up the phy until it's probed, so the resets must be in the
opposite order. The MAC reset is in device init but the PHY probe is
in device open. Device init is done first, always, while open is done
later, and only if the device is used.
Rather than move the phy probe to init, this moves the MAC reset to
open. It seems better to speed up boots that doesn't use ethernet by
skipping MAC reset than to slow them down by adding PHY probe.
Signed-off-by: Trent Piepho <tpiepho@kymetacorp.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers/net/rtl8169.c')
0 files changed, 0 insertions, 0 deletions