diff options
| author | Oleksij Rempel <o.rempel@pengutronix.de> | 2023-08-11 13:53:25 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2023-08-18 07:37:45 +0200 |
| commit | f22c8294415f80b131c1b79073b4af3a326702b3 (patch) | |
| tree | a261434acc5123a313ad920d6d0c8b8cdb74b5dd /drivers/net | |
| parent | 48c718773489f49ae2b327fd25d69488e1c3db45 (diff) | |
| download | barebox-f22c8294415f80b131c1b79073b4af3a326702b3.tar.gz barebox-f22c8294415f80b131c1b79073b4af3a326702b3.tar.xz | |
net: ksz9477: do not advertise EEE support
Do not advertise EEE support for all ksz9477 based chips. EEE needs
proper handling which we can't guarantee with limited resources.
At same time remove wrong comment and Gbit check. EEE is not coupled to
Gbit and KSZ8565 supports EEE as well. So, it seems like there is
nothing right on this comment.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://lore.barebox.org/20230811115325.2646286-2-o.rempel@pengutronix.de
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ksz9477.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/net/ksz9477.c b/drivers/net/ksz9477.c index a6a8144479..9665e0f723 100644 --- a/drivers/net/ksz9477.c +++ b/drivers/net/ksz9477.c @@ -175,12 +175,6 @@ static void ksz9477_phy_errata_setup(struct ksz_switch *priv, int port) */ ksz9477_port_mmd_write(priv, port, 0x1c, 0x04, 0x00d0); - /* Energy Efficient Ethernet (EEE) feature select must - * be manually disabled (except on KSZ8565 which is 100Mbit) - */ - if (priv->features & GBIT_SUPPORT) - ksz9477_port_mmd_write(priv, port, 0x07, 0x3c, 0x0000); - /* Register settings are required to meet data sheet * supply current specifications */ @@ -269,6 +263,8 @@ static int ksz_port_setup(struct ksz_switch *priv, int port, if (priv->features & KSZ9477_PHY_ERRATA) ksz9477_phy_errata_setup(priv, port); + ksz9477_port_mmd_write(priv, port, 0x07, 0x3c, 0x0000); + ksz_pwrite16(priv, port, 0x100 + (MII_BMCR << 1), BMCR_ANENABLE | BMCR_ANRESTART | BMCR_RESET); } else { |